tkalkirill commented on code in PR #1720:
URL: https://github.com/apache/ignite-3/pull/1720#discussion_r1122732162
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1246,12 +1279,16 @@ private void dropTableLocally(long causalityToken,
String name, UUID tblId, List
try {
int partitions = assignment.size();
+ CompletableFuture<?>[] removeStorageFromGcFutures = new
CompletableFuture<?>[partitions];
+
for (int p = 0; p < partitions; p++) {
TablePartitionId replicationGroupId = new
TablePartitionId(tblId, p);
raftMgr.stopRaftNodes(replicationGroupId);
replicaMgr.stopReplica(replicationGroupId);
+
+ removeStorageFromGcFutures[p] =
mvGc.removeStorage(replicationGroupId);
Review Comment:
We close the storages, or after changing the assigments:
`org.apache.ignite.internal.table.distributed.TableManager#handleChangeStableAssignmentEvent`
And at the `TableManager` stop:
`org.apache.ignite.internal.table.distributed.TableManager#cleanUpTablesResources`
And drop table in:
`org.apache.ignite.internal.table.distributed.TableManager#dropTableLocally`
In these places, we remove storage from GC before stopping them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
