vldpyatkov commented on code in PR #1726: URL: https://github.com/apache/ignite-3/pull/1726#discussion_r1130605208
########## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ########## @@ -0,0 +1,242 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.placementdriver; + +import static org.apache.ignite.internal.metastorage.dsl.Conditions.notExists; +import static org.apache.ignite.internal.metastorage.dsl.Conditions.or; +import static org.apache.ignite.internal.metastorage.dsl.Conditions.value; +import static org.apache.ignite.internal.metastorage.dsl.Operations.noop; +import static org.apache.ignite.internal.metastorage.dsl.Operations.put; +import static org.apache.ignite.internal.placementdriver.PlacementDriverManager.PLACEMENTDRIVER_PREFIX; + +import java.util.Map; +import java.util.Set; +import org.apache.ignite.internal.affinity.Assignment; +import org.apache.ignite.internal.cluster.management.topology.api.LogicalTopologyService; +import org.apache.ignite.internal.hlc.HybridClock; +import org.apache.ignite.internal.hlc.HybridTimestamp; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.metastorage.MetaStorageManager; +import org.apache.ignite.internal.replicator.ReplicationGroupId; +import org.apache.ignite.internal.schema.configuration.TablesConfiguration; +import org.apache.ignite.internal.thread.NamedThreadFactory; +import org.apache.ignite.internal.util.ByteUtils; +import org.apache.ignite.internal.vault.VaultManager; +import org.apache.ignite.lang.ByteArray; +import org.apache.ignite.network.ClusterNode; + +/** + * A processor to manger leases. The process is started when placement driver activates and stopped when it deactivates. + */ +public class LeaseUpdater { + /** Ignite logger. */ + private static final IgniteLogger LOG = Loggers.forClass(LeaseUpdater.class); + + /** + * Cluster cLock skew. + * TODO: IGNITE-18978 Method to comparison timestamps with clock skew. + */ + private static final long CLOCK_SKEW = 7L; + + /** Update attempts interval in milliseconds. */ + private static final long UPDATE_LEASE_MS = 200L; + + /** Lease holding interval. */ + private static final long LEASE_PERIOD = 10 * UPDATE_LEASE_MS; + + /** Metastorage manager. */ + private final MetaStorageManager msManager; + + /** Assignments tracker. */ + private final AssignmentsTracker assignmentsTracker; + + /** Topology tracker. */ + private final TopologyTracker topologyTracker; + + /** Lease tracker. */ + private final LeaseTracker leaseTracker; + + /** Cluster clock. */ + private final HybridClock clock; + + /** Closure to update leases. */ + private final Updater updater; + + /** Dedicated thread to update leases. */ + private volatile Thread updaterTread; + + /** Node name. */ + private String nodeName; + + /** + * The constructor. + * + * @param vaultManager Vault manager. + * @param msManager Metastorage manager. + * @param topologyService Topology service. + * @param tablesConfiguration Tables configuration. + * @param leaseTracker Lease tracker. + * @param clock Cluster clock. + */ + public LeaseUpdater( + VaultManager vaultManager, + MetaStorageManager msManager, + LogicalTopologyService topologyService, + TablesConfiguration tablesConfiguration, + LeaseTracker leaseTracker, + HybridClock clock + ) { + this.msManager = msManager; + this.leaseTracker = leaseTracker; + this.clock = clock; + + this.assignmentsTracker = new AssignmentsTracker(vaultManager, msManager, tablesConfiguration); + this.topologyTracker = new TopologyTracker(topologyService); + this.updater = new Updater(); + } + + /** + * Initializes the class. + */ + public void init(String nodeName) { + this.nodeName = nodeName; + + topologyTracker.startTrack(); + assignmentsTracker.startTrack(); + } + + /** + * De-initializes the class. + */ + public void deInit() { + topologyTracker.stopTrack(); + assignmentsTracker.stopTrack(); + } + + /** + * Activates a lease updater to renew leases. + */ + public void activate() { + //TODO: IGNITE-18879 Implement lease maintenance. + updaterTread = new Thread(updater, NamedThreadFactory.threadPrefix(nodeName, "lease-updater")); + + updaterTread.start(); + } + + /** + * Runnable to update lease in Metastorage. + */ + private class Updater implements Runnable { + @Override + public void run() { + while (!updaterTread.isInterrupted()) { + for (Map.Entry<ReplicationGroupId, Set<Assignment>> entry : assignmentsTracker.assignments().entrySet()) { + ReplicationGroupId grpId = entry.getKey(); + + Lease lease = leaseTracker.getLease(grpId); + + HybridTimestamp now = clock.now(); + + // Nothing holds the lease. + if (lease.getLeaseExpirationTime() == null + // The lease is near to expiration. + || now.getPhysical() > (lease.getLeaseExpirationTime().getPhysical() - LEASE_PERIOD / 2)) { + var leaseKey = ByteArray.fromString(PLACEMENTDRIVER_PREFIX + grpId); + + var newTs = new HybridTimestamp(now.getPhysical() + LEASE_PERIOD, 0); + + ClusterNode candidate = nextLeaseHolder(entry.getValue()); + + // Now nothing is holding the lease, and new lease is being granted. + if (lease.getLeaseholder() == null && candidate != null + // The lease is prolongation + || lease.getLeaseholder() != null && lease.getLeaseholder().equals(candidate) + // New lease is being granted, and the previous lease is expired. + || candidate != null && (lease.getLeaseExpirationTime() == null + || compareWithClockSkew(now, lease.getLeaseExpirationTime()) > 0)) { + byte[] leaseRaw = ByteUtils.toBytes(lease); + + Lease renewedLease = new Lease(candidate, newTs); + + msManager.invoke( + or(notExists(leaseKey), value(leaseKey).eq(leaseRaw)), + put(leaseKey, ByteUtils.toBytes(renewedLease)), + noop() + ); + } + } + } + + try { + Thread.sleep(UPDATE_LEASE_MS); + } catch (InterruptedException e) { + LOG.warn("Lease updater is interrupted"); + } + } + } + } + + /** + * Compares two timestamps with the clock skew. + * TODO: IGNITE-18978 Method to comparison timestamps with clock skew. + * Review Comment: Is it not right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
