vldpyatkov commented on code in PR #1726: URL: https://github.com/apache/ignite-3/pull/1726#discussion_r1130620795
########## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/AssignmentsTracker.java: ########## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.placementdriver; + +import static java.util.concurrent.CompletableFuture.completedFuture; +import static org.apache.ignite.internal.utils.RebalanceUtil.STABLE_ASSIGNMENTS_PREFIX; + +import java.nio.charset.StandardCharsets; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import org.apache.ignite.configuration.notifications.ConfigurationListener; +import org.apache.ignite.configuration.notifications.ConfigurationNotificationEvent; +import org.apache.ignite.internal.affinity.Assignment; +import org.apache.ignite.internal.logger.IgniteLogger; +import org.apache.ignite.internal.logger.Loggers; +import org.apache.ignite.internal.metastorage.EntryEvent; +import org.apache.ignite.internal.metastorage.MetaStorageManager; +import org.apache.ignite.internal.metastorage.WatchEvent; +import org.apache.ignite.internal.metastorage.WatchListener; +import org.apache.ignite.internal.replicator.ReplicationGroupId; +import org.apache.ignite.internal.schema.configuration.ExtendedTableConfiguration; +import org.apache.ignite.internal.schema.configuration.TablesConfiguration; +import org.apache.ignite.internal.table.distributed.replicator.TablePartitionId; +import org.apache.ignite.internal.util.ByteUtils; +import org.apache.ignite.internal.util.CollectionUtils; +import org.apache.ignite.internal.util.Cursor; +import org.apache.ignite.internal.vault.VaultEntry; +import org.apache.ignite.internal.vault.VaultManager; +import org.apache.ignite.lang.ByteArray; + +/** + * The class tracks assignment of all replication groups. + */ +public class AssignmentsTracker { + /** Ignite logger. */ + private static final IgniteLogger LOG = Loggers.forClass(AssignmentsTracker.class); + + /** Vault manager. */ + private final VaultManager vaultManager; + + /** Metastorage manager. */ + private final MetaStorageManager msManager; + + /** Tables configuration. */ + private final TablesConfiguration tablesCfg; + + /** Map replication group id to assignment nodes. */ + private Map<ReplicationGroupId, Set<Assignment>> groupAssignments; + + /** Assignment configuration listener. */ + private final AssignmentsCfgListener assignmentsCfgListener; + + /** Assignment Metastorage watch listener. */ + private final AssignmentsListener assignmentsListener; + + /** + * The constructor. + * + * @param vaultManager Vault manager. + * @param msManager Metastorage manager. + * @param tablesCfg Table configuration. + */ + public AssignmentsTracker(VaultManager vaultManager, MetaStorageManager msManager, TablesConfiguration tablesCfg) { + this.vaultManager = vaultManager; + this.msManager = msManager; + this.tablesCfg = tablesCfg; + + this.groupAssignments = new ConcurrentHashMap<>(); + this.assignmentsCfgListener = new AssignmentsCfgListener(); + this.assignmentsListener = new AssignmentsListener(); + } + + /** + * Restores assignments form Vault and subscribers on further updates. + */ + public void startTrack() { + ((ExtendedTableConfiguration) tablesCfg.tables().any()).assignments().listen(assignmentsCfgListener); + msManager.registerPrefixWatch(ByteArray.fromString(STABLE_ASSIGNMENTS_PREFIX), assignmentsListener); + + try (Cursor<VaultEntry> cursor = vaultManager.range( + ByteArray.fromString(STABLE_ASSIGNMENTS_PREFIX), + ByteArray.fromString(incrementLastChar(STABLE_ASSIGNMENTS_PREFIX)) + )) { + for (VaultEntry entry : cursor) { + String key = entry.key().toString(); + + key = key.replace(STABLE_ASSIGNMENTS_PREFIX, ""); + + TablePartitionId grpId = TablePartitionId.fromString(key); + + Set<Assignment> assignments = ByteUtils.fromBytes(entry.value()); + + groupAssignments.put(grpId, assignments); + } + } + + LOG.info("Assignment cache initialized for placement driver [groupAssignments={}]", groupAssignments); + } + + private static String incrementLastChar(String str) { + char lastChar = str.charAt(str.length() - 1); + + return str.substring(0, str.length() - 1) + (char) (lastChar + 1); + } + + /** + * Stops the tracker. + */ + public void stopTrack() { + msManager.unregisterWatch(assignmentsListener); + ((ExtendedTableConfiguration) tablesCfg.tables().any()).assignments().stopListen(assignmentsCfgListener); + } + + /** + * Gets assignments. + * + * @return Map replication group id to its assignment. + */ + public Map<ReplicationGroupId, Set<Assignment>> assignments() { + return groupAssignments; + } + + /** + * Configuration assignments listener. + */ + private class AssignmentsCfgListener implements ConfigurationListener<byte[]> { + @Override + public CompletableFuture<?> onUpdate(ConfigurationNotificationEvent<byte[]> assignmentsCtx) { + ExtendedTableConfiguration tblCfg = assignmentsCtx.config(ExtendedTableConfiguration.class); + + UUID tblId = tblCfg.id().value(); + + LOG.debug("Table assignments configuration update for placement driver [revision={}, tblId={}]", + assignmentsCtx.storageRevision(), tblId); + + List<Set<Assignment>> tableAssignments = + assignmentsCtx.newValue() == null ? null : ByteUtils.fromBytes(assignmentsCtx.newValue()); + + boolean leaseRenewalRequired = false; + + for (int part = 0; part < tblCfg.partitions().value(); part++) { + var replicationGrpId = new TablePartitionId(tblId, part); + + if (tableAssignments == null) { + groupAssignments.remove(replicationGrpId); + } else { + Set<Assignment> prevAssignment = groupAssignments.put(replicationGrpId, tableAssignments.get(part)); + + if (CollectionUtils.nullOrEmpty(prevAssignment)) { + leaseRenewalRequired = true; + } + } + } + + if (leaseRenewalRequired) { + triggerToRenewLeases(); + } + + return completedFuture(null); + } + } + + /** + * Metastorage assignments watch. Review Comment: If you think it is better, I will fix everywhere in our code. But currently Metastorage is used frequently as I described above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
