skorotkov commented on code in PR #10624:
URL: https://github.com/apache/ignite/pull/10624#discussion_r1160413316
##########
modules/ducktests/tests/ignitetest/services/utils/control_utility.py:
##########
@@ -220,6 +220,96 @@ def snapshot_create(self, snapshot_name: str, timeout_sec:
int = 60):
raise TimeoutError(f'Failed to wait for the snapshot operation to
complete: '
f'snapshot_name={snapshot_name} in {timeout_sec}
seconds.')
+ def incremental_snapshot_create(self, snapshot_name: str, exp_increment:
int, timeout_sec: int = 60):
Review Comment:
I think it worth to eliminate the dublication in
*incremental_snapshot_create* and *snapshot_create*. Extract common parts. May
be use the same function passing the *is_increment* as optional parameter.
Say can we use the --snapshot status for both cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
