skorotkov commented on code in PR #10624:
URL: https://github.com/apache/ignite/pull/10624#discussion_r1160425661


##########
modules/ducktests/tests/ignitetest/tests/util.py:
##########
@@ -79,10 +80,11 @@ def start_app(_from, _to):
                 "entrySize": data_gen_params.entry_size,
                 "from": _from,
                 "to": _to,
-                "indexCount": data_gen_params.index_count
+                "indexCount": data_gen_params.index_count,
+                "transactional": data_gen_params.transactional
             },
             shutdown_timeout_sec=timeout)
-        app.start_async()
+        app.start()

Review Comment:
   Do we really need to change this to sync? Shouldn't we just  start apps 
async and  *await_started()* them in the caller?  
   
   Now it looks like just an increase of the total time for the apps start. Do 
I miss anything?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to