tkalkirill commented on code in PR #1912:
URL: https://github.com/apache/ignite-3/pull/1912#discussion_r1161445416
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -235,7 +236,36 @@ public <T extends RaftGroupService> CompletableFuture<T>
startRaftGroupNode(
}
try {
- return startRaftGroupNodeInternal(nodeId, configuration, lsnr,
eventsLsnr, groupOptions, raftServiceFactory);
+ return startRaftGroupNodeInternal(nodeId, configuration, lsnr,
eventsLsnr, groupOptions, raftServiceFactory, null);
+ } finally {
+ busyLock.leaveBusy();
+ }
+ }
+
+ @Override
+ public CompletableFuture<RaftGroupService> startRaftGroupNode(
+ RaftNodeId nodeId,
+ PeersAndLearners configuration,
+ RaftGroupListener lsnr,
+ RaftGroupEventsListener eventsLsnr,
+ RaftNodeDisruptorConfiguration ownFsmCallerExecutorDisruptorConfig
Review Comment:
Look, `RaftGroupOptions` is in module `ignite-raft` and `RaftManager` (as
well as `RaftNodeDisruptorConfiguration`) are in module `ignite-raft-api`, I
don't want to inflate the amount of work in this ticket, let's not do it in
**IGNITE-18273**.
IGNITE-18273 already indicates what needs to be done and within it, we will
move the configuration, I will mention this in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
