rpuch commented on code in PR #1912:
URL: https://github.com/apache/ignite-3/pull/1912#discussion_r1161474223
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -235,7 +236,36 @@ public <T extends RaftGroupService> CompletableFuture<T>
startRaftGroupNode(
}
try {
- return startRaftGroupNodeInternal(nodeId, configuration, lsnr,
eventsLsnr, groupOptions, raftServiceFactory);
+ return startRaftGroupNodeInternal(nodeId, configuration, lsnr,
eventsLsnr, groupOptions, raftServiceFactory, null);
+ } finally {
+ busyLock.leaveBusy();
+ }
+ }
+
+ @Override
+ public CompletableFuture<RaftGroupService> startRaftGroupNode(
+ RaftNodeId nodeId,
+ PeersAndLearners configuration,
+ RaftGroupListener lsnr,
+ RaftGroupEventsListener eventsLsnr,
+ RaftNodeDisruptorConfiguration ownFsmCallerExecutorDisruptorConfig
Review Comment:
At least `RaftServer` is in the same module as `RaftGroupOptions`, so it
seems that it is possible to pass `RaftNodeDisruptorConfiguration` to
`RaftServer` inside of `RaftGroupOptions` easily. Does it take a lot of work?
On the other hand, `if this is done, `RaftServer` will become simpler right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
