[GitHub] [ignite-3] xtern commented on a diff in pull request #1880: IGNITE-18985 Sql. Jdbc. Integration with transaction

[via GitHub]

xtern commented on code in PR #1880:
URL: https://github.com/apache/ignite-3/pull/1880#discussion_r1164040869


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java:
##########
@@ -287,6 +300,26 @@ public CompletableFuture<JdbcMetaPrimaryKeysResult> 
primaryKeysMetaAsync(JdbcMet
         return meta.getPrimaryKeys(req.schemaName(), 
req.tableName()).thenApply(JdbcMetaPrimaryKeysResult::new);
     }
 
+    /** {@inheritDoc} */
+    @Override
+    public CompletableFuture<JdbcFinishTxResult> finishTxAsync(long 
connectionId, boolean commit) {
+        JdbcConnectionContext connectionContext;
+
+        try {
+            connectionContext = 
resources.get(connectionId).get(JdbcConnectionContext.class);

Review Comment:
   Currently, if the resource (ConnectionContext) is released (in 
ClientResourceRegistry#close) the active transaction is rolled back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org