[GitHub] [ignite-3] xtern commented on a diff in pull request #1880: IGNITE-18985 Sql. Jdbc. Integration with transaction

[via GitHub]

xtern commented on code in PR #1880:
URL: https://github.com/apache/ignite-3/pull/1880#discussion_r1165537402


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java:
##########
@@ -442,6 +481,22 @@ private SessionId recreateSession(@Nullable SessionId 
expectedSessionId) {
             }
         }
 
+        private Transaction getOrStartTransaction() {
+            return tx == null ? tx = igniteTransactions.begin() : tx;

Review Comment:
   Thanks, I believe I've fixed this.
   
   Added context close flag.
   Transaction creation has been moved above batch asynchronous processing.
   Added javadocs that methods are not thread safe.



##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java:
##########
@@ -442,6 +481,22 @@ private SessionId recreateSession(@Nullable SessionId 
expectedSessionId) {
             }
         }
 
+        private Transaction getOrStartTransaction() {
+            return tx == null ? tx = igniteTransactions.begin() : tx;

Review Comment:
   Thanks, I believe I've fixed it.
   
   Added context close flag.
   Transaction creation has been moved above batch asynchronous processing.
   Added javadocs that methods are not thread safe.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org