korlov42 commented on code in PR #1880:
URL: https://github.com/apache/ignite-3/pull/1880#discussion_r1164191710
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java:
##########
@@ -228,16 +240,17 @@ public CompletableFuture<JdbcBatchExecuteResult>
batchPrepStatementAsync(long co
});
}
- private CompletableFuture<Long> executeAndCollectUpdateCount(long
connectionId, String sql, Object[] arg) {
- var context =
createQueryContext(JdbcStatementType.UPDATE_STATEMENT_TYPE);
-
+ private CompletableFuture<Long> executeAndCollectUpdateCount(long
connectionId, boolean autoCommit, String sql, Object[] arg) {
JdbcConnectionContext connectionContext;
try {
connectionContext =
resources.get(connectionId).get(JdbcConnectionContext.class);
} catch (IgniteInternalCheckedException exception) {
return CompletableFuture.failedFuture(new
IgniteInternalException(Client.CONNECTION_ERR));
}
+ Transaction tx = autoCommit ? null :
connectionContext.getOrStartTransaction();
+ var context =
createQueryContext(JdbcStatementType.UPDATE_STATEMENT_TYPE, tx);
Review Comment:
keyword `var` is not allowed in this context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
