korlov42 commented on code in PR #1880:
URL: https://github.com/apache/ignite-3/pull/1880#discussion_r1165104826


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/JdbcQueryEventHandlerImpl.java:
##########
@@ -442,6 +481,22 @@ private SessionId recreateSession(@Nullable SessionId 
expectedSessionId) {
             }
         }
 
+        private Transaction getOrStartTransaction() {
+            return tx == null ? tx = igniteTransactions.begin() : tx;

Review Comment:
   Please take a look at how batch execution is implemented. The execution of a 
next query from the batch is chained to the result future of a previous one. 
Thus, only the first query will be started from channel worker thread. Besides, 
there is a bug in JdbcConnectionContext allowing to execute queries on a closed 
context. Although executing a query on a closed context by itself has no effect 
on the cluster, when combined with an explicit tx (explicit to the query 
engine) it causes a number of locks to be held forever



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to