zstan commented on code in PR #1939:
URL: https://github.com/apache/ignite-3/pull/1939#discussion_r1170285475
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteTypeFactory.java:
##########
@@ -72,6 +74,26 @@ public class IgniteTypeFactory extends JavaTypeFactoryImpl {
/** A registry that contains custom data types. **/
private final CustomDataTypes customDataTypes;
+ /** Contains java types internally mapped into appropriate rel types. */
+ private static final Map<Class<?>, Supplier<RelDataType>>
implementedJavaTypes = new IdentityHashMap<>();
+
+ {
+ {
+ implementedJavaTypes.put(LocalDate.class, () ->
+ createTypeWithNullability(createSqlType(SqlTypeName.DATE),
true));
+ implementedJavaTypes.put(LocalTime.class, () ->
+ createTypeWithNullability(createSqlType(SqlTypeName.TIME),
true));
+ implementedJavaTypes.put(LocalDateTime.class, () ->
Review Comment:
I suppose we already have such a tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
