zstan commented on code in PR #1939:
URL: https://github.com/apache/ignite-3/pull/1939#discussion_r1171462416
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java:
##########
@@ -89,6 +91,33 @@ public class TypeUtils {
SqlTypeName.INTERVAL_YEAR_MONTH
);
+ private Set<Class<?>> correctParamClasses;
+
+ {
+ {
+ correctParamClasses =
Arrays.stream(ColumnType.values()).map(ColumnType::columnTypeToClass).collect(Collectors.toSet());
+
+ correctParamClasses.add(boolean.class);
+ correctParamClasses.add(byte.class);
+ correctParamClasses.add(short.class);
+ correctParamClasses.add(int.class);
+ correctParamClasses.add(long.class);
+ correctParamClasses.add(float.class);
+ correctParamClasses.add(double.class);
+ correctParamClasses.add(char[].class);
+ correctParamClasses.add(char.class);
+ }
+ }
+
+ public static TypeUtils instance() {
+ return INSTANCE;
Review Comment:
whats the problem with initialization on demand ? If dyn params is not
touched - no correctParamInstance instance is initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
