tkalkirill commented on code in PR #1952:
URL: https://github.com/apache/ignite-3/pull/1952#discussion_r1173492713
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -221,7 +228,8 @@ private void handleUpdateCommand(UpdateCommand cmd, long
commandIndex, long comm
txsPendingRowIds.computeIfAbsent(cmd.txId(), entry -> new
HashSet<>()).add(rowId);
storage.lastApplied(commandIndex, commandTerm);
- }
+ },
+ lowWatermarkSupplier.get()
Review Comment:
Since we are tied to working with indexes, they will soon be redone, so in
order to avoid code duplication and ease of use, the logic associated with GC
is in `StorageUpdateHandler`, I suggest getting a ticket for technical debt and
removing GC from `StorageUpdateHandler` after redone the indices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
