tkalkirill commented on code in PR #1952:
URL: https://github.com/apache/ignite-3/pull/1952#discussion_r1173494919
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/IndexBaseTest.java:
##########
@@ -129,7 +130,8 @@ void setUp(@InjectConfiguration DataStorageConfiguration
dsCfg) {
PARTITION_ID,
new TestPartitionDataStorage(storage),
DummyInternalTableImpl.createTableIndexStoragesSupplier(indexes),
- dsCfg
+ dsCfg,
+ new PendingComparableValuesTracker<>(HybridTimestamp.MAX_VALUE)
Review Comment:
So that when inserting into a table, the GC always worked for us.
> And another question second time - are you sure that adding all this stuff
to storage update handler is a good idea?
answered above.
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/IndexBaseTest.java:
##########
@@ -129,7 +130,8 @@ void setUp(@InjectConfiguration DataStorageConfiguration
dsCfg) {
PARTITION_ID,
new TestPartitionDataStorage(storage),
DummyInternalTableImpl.createTableIndexStoragesSupplier(indexes),
- dsCfg
+ dsCfg,
+ new PendingComparableValuesTracker<>(HybridTimestamp.MAX_VALUE)
Review Comment:
So that when inserting into a table, the GC always worked for us.
> And another question second time - are you sure that adding all this stuff
to storage update handler is a good idea?
answered above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
