sanpwc commented on code in PR #1968:
URL: https://github.com/apache/ignite-3/pull/1968#discussion_r1180267067
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java:
##########
@@ -120,21 +125,28 @@ public void setUp() throws Exception {
metaStorageManager.put(zonesLogicalTopologyVersionKey(),
longToBytes(0));
+ ConfigurationRegistry clusterConfigRegistry =
clusterCfgMgr.configurationRegistry();
+
+ Consumer<Function<Long, CompletableFuture<?>>> registry =
+ c ->
clusterConfigRegistry.listenUpdateStorageRevision(c::apply);
+
distributionZoneManager = new DistributionZoneManager(
zonesConfiguration,
tablesConfiguration,
metaStorageManager,
logicalTopologyService,
vaultMgr,
+ registry,
"test"
);
vaultMgr.start();
clusterCfgMgr.start();
metaStorageManager.start();
- distributionZoneManager.start();
- metaStorageManager.deployWatches();
+ deployWatchesAndUpdateMetaStorageRevision(metaStorageManager);
Review Comment:
Why do we deploy watches before starting the distributionZoneManager? It
seems incorrect, because common practice is to deploy watches after all
components start up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
