sanpwc commented on code in PR #1968:
URL: https://github.com/apache/ignite-3/pull/1968#discussion_r1180363294
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerWatchListenerTest.java:
##########
@@ -136,20 +141,20 @@ void testStaleVaultRevisionOnZoneManagerStart() throws
InterruptedException {
mockVaultZonesLogicalTopologyKey(nodes);
- distributionZoneManager.start();
+ startDistributionZoneManager();
verify(keyValueStorage, timeout(1000).times(2)).invoke(any());
assertDataNodesForZone(DEFAULT_ZONE_ID, null, keyValueStorage);
}
@Test
- void testDataNodesUpdatedOnZoneManagerStart() throws InterruptedException {
+ void testDataNodesUpdatedOnZoneManagerStart() throws Exception {
Set<String> nodes = Set.of("node1", "node2");
mockVaultZonesLogicalTopologyKey(nodes);
- distributionZoneManager.start();
+ startDistributionZoneManager();
Review Comment:
There's no need in such method
```
private void startDistributionZoneManager() throws Exception {
deployWatchesAndUpdateMetaStorageRevision(metaStorageManager);
distributionZoneManager.start();
}
```
because it's inappropriate encapsulation pattern: dzm start semantically
doesn't include deploy watches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
