ibessonov commented on code in PR #1976:
URL: https://github.com/apache/ignite-3/pull/1976#discussion_r1180308654
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/GarbageCollector.java:
##########
@@ -153,69 +154,81 @@ boolean tryAddToGcQueue(WriteBatchWithIndex writeBatch,
RowId rowId, HybridTimes
/**
* Polls an element for vacuum. See {@link
org.apache.ignite.internal.storage.MvPartitionStorage#pollForVacuum(HybridTimestamp)}.
*
- * @param batch Write batch.
* @param lowWatermark Low watermark.
- * @return Garbage collected element.
+ * @return Garbage collected element descriptor.
* @throws RocksDBException If failed to collect the garbage.
*/
- @Nullable BinaryRowAndRowId pollForVacuum(WriteBatchWithIndex batch,
HybridTimestamp lowWatermark) throws RocksDBException {
- ColumnFamilyHandle partCf = helper.partCf;
-
+ @Nullable GcEntry peek(HybridTimestamp lowWatermark) {
// We retrieve the first element of the GC queue and seek for it in
the data CF.
// However, the element that we need to garbage collect is the next
(older one) element.
// First we check if there's anything to garbage collect. If the
element is a tombstone we remove it.
// If the next element exists, that should be the element that we want
to garbage collect.
- try (RocksIterator gcIt = db.newIterator(gcQueueCf,
helper.upperBoundReadOpts)) {
+ try (
+ RocksIterator foo = db.newIterator(gcQueueCf,
helper.upperBoundReadOpts);
Review Comment:
Oops
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
