ibessonov commented on code in PR #1976:
URL: https://github.com/apache/ignite-3/pull/1976#discussion_r1180312623
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -324,7 +324,10 @@ private void handleTxCleanupCommand(TxCleanupCommand cmd,
long commandIndex, lon
Set<RowId> pendingRowIds = txsPendingRowIds.getOrDefault(txId,
Collections.emptySet());
if (cmd.commit()) {
- storage.runConsistently(() -> {
+ storage.runConsistently(locker -> {
+ //TODO Split & sort.
Review Comment:
I'll fix it. It's not really dangerous right now, I guess, because all
insertions are protected by external locks in transactions, but nonetheless.
Code hygiene is never a bad thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
