sergeyuttsel commented on code in PR #1968:
URL: https://github.com/apache/ignite-3/pull/1968#discussion_r1182534708
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerConfigurationChangesTest.java:
##########
@@ -120,21 +125,28 @@ public void setUp() throws Exception {
metaStorageManager.put(zonesLogicalTopologyVersionKey(),
longToBytes(0));
+ ConfigurationRegistry clusterConfigRegistry =
clusterCfgMgr.configurationRegistry();
+
+ Consumer<Function<Long, CompletableFuture<?>>> registry =
+ c ->
clusterConfigRegistry.listenUpdateStorageRevision(c::apply);
+
distributionZoneManager = new DistributionZoneManager(
zonesConfiguration,
tablesConfiguration,
metaStorageManager,
logicalTopologyService,
vaultMgr,
+ registry,
"test"
);
vaultMgr.start();
clusterCfgMgr.start();
metaStorageManager.start();
- distributionZoneManager.start();
- metaStorageManager.deployWatches();
+ deployWatchesAndUpdateMetaStorageRevision(metaStorageManager);
Review Comment:
This approach was introduced by Aleksandr Polovtsev. I just reused it. I
will create another ticket to fix it properly.
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -1366,10 +1379,10 @@ private void assertNotEqualsDataNodesForZone(int
zoneId, @Nullable Set<String> c
));
}
- private void startDistributionZoneManager() throws NodeStoppingException {
- distributionZoneManager.start();
+ private void startDistributionZoneManager() throws Exception {
+ deployWatchesAndUpdateMetaStorageRevision(metaStorageManager);
Review Comment:
I will create another ticket to fix it properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
