sergeyuttsel commented on code in PR #1968:
URL: https://github.com/apache/ignite-3/pull/1968#discussion_r1182535425
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerWatchListenerTest.java:
##########
@@ -136,20 +141,20 @@ void testStaleVaultRevisionOnZoneManagerStart() throws
InterruptedException {
mockVaultZonesLogicalTopologyKey(nodes);
- distributionZoneManager.start();
+ startDistributionZoneManager();
verify(keyValueStorage, timeout(1000).times(2)).invoke(any());
assertDataNodesForZone(DEFAULT_ZONE_ID, null, keyValueStorage);
}
@Test
- void testDataNodesUpdatedOnZoneManagerStart() throws InterruptedException {
+ void testDataNodesUpdatedOnZoneManagerStart() throws Exception {
Set<String> nodes = Set.of("node1", "node2");
mockVaultZonesLogicalTopologyKey(nodes);
- distributionZoneManager.start();
+ startDistributionZoneManager();
Review Comment:
I will create another ticket to fix it properly.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/MockedStructuresTest.java:
##########
@@ -162,13 +177,15 @@ public class MockedStructuresTest extends
IgniteAbstractTest {
@InjectConfiguration
private TablesConfiguration tblsCfg;
- @InjectConfiguration("mock.distributionZones.zone123{dataStorage.name = "
+ ENGINE_NAME + ", zoneId = 1}")
+ @InjectConfiguration("mock.distributionZones." + ZONE_NAME +
"{dataStorage.name = " + ENGINE_NAME + ", zoneId = 1}")
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
