sanpwc commented on code in PR #2041:
URL: https://github.com/apache/ignite-3/pull/2041#discussion_r1190132269
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -283,6 +288,15 @@ public DistributionZoneManager(
);
topVerTracker = new PendingComparableValuesTracker<>(0L);
+
+ rebalanceEngine = new DistributionZoneRebalanceEngine(
+ stopGuard,
+ busyLock,
+ zonesConfiguration,
+ tablesConfiguration,
+ metaStorageManager,
+ this
Review Comment:
Generally it's not a bad practice. It's about some multitheading threats
that aren't applicable here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
