sanpwc commented on code in PR #2059:
URL: https://github.com/apache/ignite-3/pull/2059#discussion_r1191161452
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneAwaitDataNodesTest.java:
##########
@@ -367,20 +377,30 @@ void testRemoveZoneWhileAwaitingDataNodes() throws
Exception {
CompletableFuture<Set<String>> dataNodesFut1 =
distributionZoneManager.topologyVersionedDataNodes(zoneId, 106);
+ doAnswer(invocation -> {
Review Comment:
What are we trying to achieve with this mock? Why it's not enough to simply
remove zone, meaning just call
`distributionZoneManager.dropZone(zoneName).get();`
By the way if I do this, test might fail because instead of expected
`DistributionZoneWasRemovedException` `DistributionZoneNotFoundException` will
be thrown from
`org.apache.ignite.internal.distributionzones.DistributionZonesUtil#getZoneById`.
We should also fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
