alievmirza commented on code in PR #2059:
URL: https://github.com/apache/ignite-3/pull/2059#discussion_r1191249715
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -1351,8 +1353,8 @@ private void preparePrerequisites() throws Exception {
assertDataNodesForZone(1, clusterNodesNames, keyValueStorage);
- assertZoneScaleUpChangeTriggerKey(1, 1, keyValueStorage);
- assertZoneScaleDownChangeTriggerKey(1, 1, keyValueStorage);
+ assertZoneScaleUpChangeTriggerKey(PREREQUISITE_REVISION, 1,
keyValueStorage);
Review Comment:
let's check here that `assertZoneScaleUp/DownChangeTriggerKey` are not null
and equal to each other, and after that
Lets initialise here `PREREQUISITE_REVISION` with the value from trigger key
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -721,29 +723,29 @@ void testCleanUpAfterSchedulers() throws Exception {
ZoneState zoneState = distributionZoneManager.zonesTimers().get(1);
- zoneState.nodesToAddToDataNodes(Set.of("D"), 3);
- zoneState.nodesToAddToDataNodes(Set.of("E"), 4);
- zoneState.nodesToRemoveFromDataNodes(Set.of("C"), 7);
+ zoneState.nodesToAddToDataNodes(Set.of("D"), PREREQUISITE_REVISION +
2);
Review Comment:
please, for this and all test like testVariousScaleUpScaleDownScenarios*
do not use PREREQUISITE_REVISION + x construction, but use
1000 + n as a revision, where n is a value before your changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
