sanpwc commented on code in PR #2072:
URL: https://github.com/apache/ignite-3/pull/2072#discussion_r1194624986
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -260,14 +265,20 @@ void testDropZoneDoNotPropagateDataNodesAfterScaleUp()
throws Exception {
assertDataNodesForZone(1, clusterNodesNames2, keyValueStorage);
- assertZoneScaleUpChangeTriggerKey(1, 1, keyValueStorage);
+ assertNotNull(keyValueStorage.get(zoneDataNodesKey(1).bytes()).value(),
Review Comment:
Seems that we already checked exact equality of data nodes. See line above.
So that NotNull check check dataNodes is useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
