sanpwc commented on code in PR #2072:
URL: https://github.com/apache/ignite-3/pull/2072#discussion_r1194734428
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerWatchListenerTest.java:
##########
@@ -36,74 +36,18 @@
import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.verify;
-import java.util.Collections;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
import org.apache.ignite.internal.hlc.HybridTimestamp;
import org.apache.ignite.internal.metastorage.dsl.Conditions;
import org.apache.ignite.internal.metastorage.dsl.Operations;
-import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
/**
* Tests distribution zones logical topology changes and reaction to that
changes.
*/
//TODO: IGNITE-18564 Add tests with not default distribution zones, when
distributionZones.change.trigger per zone will be created.
public class DistributionZoneManagerWatchListenerTest extends
BaseDistributionZoneManagerTest {
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-19255";)
- @Test
- void testDataNodesOfDefaultZoneUpdatedOnWatchListenerEvent() throws
Exception {
Review Comment:
As Sergey told
"testDataNodesOfDefaultZoneUpdatedOnWatchListenerEvent was removed because
we have another tests for this logic, for example:
testDataNodesPropagationAfterScaleUpTriggered and
testDataNodesPropagationAfterScaleDownTriggered. This test checked that data
nodes value was changed after topology updating. Now we have many other tests
for this logic."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
