sanpwc commented on code in PR #1958:
URL: https://github.com/apache/ignite-3/pull/1958#discussion_r1196387272
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -81,11 +70,21 @@ public class DistributionZoneManagerScaleUpTest extends
BaseDistributionZoneMana
private static final int ZONE_1_ID = 1;
- private static final LogicalNode NODE_1 = new LogicalNode("1", "A", new
NetworkAddress("localhost", 123));
+ private static final LogicalNode NODE_1 = new LogicalNode("1", "node1",
new NetworkAddress("localhost", 123));
- private static final LogicalNode NODE_2 = new LogicalNode("2", "B", new
NetworkAddress("localhost", 123));
+ private static final LogicalNode NODE_2 = new LogicalNode("2", "node2",
new NetworkAddress("localhost", 123));
- private static final LogicalNode NODE_3 = new LogicalNode("3", "C", new
NetworkAddress("localhost", 123));
+ private static final LogicalNode NODE_3 = new LogicalNode("3", "node3",
new NetworkAddress("localhost", 123));
+
+ private static final Node A = new Node("A", "A");
Review Comment:
Here and there, it's better to have different values for name and id.
Because otherwise we might miss some assertion issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
