sanpwc commented on code in PR #1958:
URL: https://github.com/apache/ignite-3/pull/1958#discussion_r1196785421


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1355,7 +1373,16 @@ public CompletableFuture<Void> onUpdate(WatchEvent evt) {
 
                     assert newDataNodes != null : "Data nodes was not 
initialized.";
 
-                    zoneState.nodes(newDataNodes);
+                    String filter;
+
+                    try {
+                        filter = getZoneById(zonesConfiguration, 
zoneId).filter().value();
+                    } catch (DistributionZoneNotFoundException ignored) {

Review Comment:
   What do you mean? I believe that zone won't be deleted from local 
configuration before we will retrieve corresponding notification from meta 
storage which isn't possible because we are in ms notification thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to