alievmirza commented on code in PR #2070:
URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1211650575
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/distribution/zones/ItDistributionZonesFilterTest.java:
##########
@@ -220,15 +199,15 @@ void testFilteredEmptyDataNodesDoNotTriggerRebalance()
throws Exception {
TablePartitionId partId = new TablePartitionId(table.tableId(), 0);
// Table was created after both nodes was up, so there wasn't any
rebalance.
- assertPendingStableAreNull(metaStorageManager, partId);
+ assertPendingsAreNull(metaStorageManager, partId);
Review Comment:
This method was needed to check there wasn't any rebalance at all, now we
check only pending, is this correct to check like this the absence of a
rebalance?
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/distribution/zones/ItDistributionZonesFilterTest.java:
##########
@@ -126,14 +124,6 @@ void testFilteredDataNodesPropagatedToStable() throws
Exception {
TablePartitionId partId = new TablePartitionId(table.tableId(), 0);
- assertValueInStorage(
Review Comment:
We somehow how to check that stable has been actually rewritten. Now we only
check it at the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
