kgusakov commented on code in PR #2070:
URL: https://github.com/apache/ignite-3/pull/2070#discussion_r1214058313
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/distribution/zones/ItDistributionZonesFilterTest.java:
##########
@@ -298,7 +295,16 @@ void
testEmptyDataNodesDoNotPropagatedToStableAfterAlteringFilter() throws Excep
waitDataNodeAndListenersAreHandled(metaStorageManager, 2);
- assertPendingStableAreNull(metaStorageManager, partId);
+ // TODO: https://issues.apache.org/jira/browse/IGNITE-19425 here we
should have no nodes,
+ // which pass the filter, when dataNodes from DistributionZoneManager
will be used
+ assertValueInStorage(
Review Comment:
The name and semantic of the test is
testEmptyDataNodesDoNotPropagatedToStableAfterAlteringFilter, so, I thought it
will be strange to check the pendings in the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
