AMashenkov commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254148000
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/AbstractNode.java:
##########
@@ -161,7 +161,7 @@ protected void checkState() throws Exception {
throw new ExecutionCancelledException();
}
if (Thread.interrupted()) {
- throw new
IgniteInternalCheckedException(OPERATION_INTERRUPTED_ERR, "Thread was
interrupted.");
+ throw new IgniteInternalCheckedException(RUNTIME_EXECUTION_ERR,
"Thread was interrupted.");
Review Comment:
Execution nodes are run in SQL query pool.
If thread is interrupted that means pool has been stopped and query was
cancelled.
So, we should never get here because of `context.isCancelled()` returns
`true`, otherwise there is a race between context state changing and pool
stopping, so we should throw ExecutionCancelledException, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
