lowka commented on code in PR #2271:
URL: https://github.com/apache/ignite-3/pull/2271#discussion_r1254169795
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashAggregateNode.java:
##########
@@ -77,11 +75,9 @@ public HashAggregateNode(
this.accFactory = accFactory;
this.rowFactory = rowFactory;
- ImmutableBitSet.Builder b = ImmutableBitSet.builder();
+ assert grpSets.size() <= Byte.MAX_VALUE : "Too many grouping sets";
- if (grpSets.size() > Byte.MAX_VALUE) {
- throw new
IgniteInternalException(TOO_MANY_GROUPING_EXPRESSIONS_ERR, "Too many groups");
- }
+ ImmutableBitSet.Builder b = ImmutableBitSet.builder();
Review Comment:
I tried to handle this case at the validation stage (to reject queries with
more than 128 groups sets), but irregardless of how many grouping sets a query
has, grpSets.size() is always 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
