xtern commented on PR #2282: URL: https://github.com/apache/ignite-3/pull/2282#issuecomment-1630724728
> You forgot to adjust folowing places: > > * RecordMarshallerTest; besides, this test should be moved from testFixtures > > * org.apache.ignite.internal.sql.engine.util.TypeUtils#columnType2NativeType > > * org.apache.ignite.client.fakes.FakeIgniteTables#getAllColumnsSchema > > * org.apache.ignite.internal.table.ItThinClientColocationTest#testClientAndServerColocationHashesAreSame > > * org.apache.ignite.internal.runner.app.PlatformTestNodeRunner.ColocationHashJob > > * org.apache.ignite.internal.schema.RowTest#fixSizedColumns > > * org.apache.ignite.internal.schema.RowTest#nullableFixSizedColumns > > * org.apache.ignite.internal.storage.index.BinaryTupleComparatorTest#allTypes Done, thanks. > `ItJdbcMetadataSelfTest` requires updaing. See > > > // Add columns with All supported types. > > EnumSet excludeTypes = EnumSet > > .of(ColumnType.TIMESTAMP, ColumnType.BOOLEAN, ColumnType.NUMBER, ColumnType.BITMASK, ColumnType.DURATION, > > ColumnType.PERIOD, ColumnType.NULL); > Also see `ItJdbcMetadataSelfTest:: dataTypeToJavaCls(int dataType, String typeName)` and ` ItJdbcMetadataSelfTest:: checkMeta(ResultSetMetaData meta)`. Done, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
