korlov42 commented on code in PR #2282:
URL: https://github.com/apache/ignite-3/pull/2282#discussion_r1263469697
##########
modules/binary-tuple/src/test/java/org/apache/ignite/internal/binarytuple/BinaryTupleTest.java:
##########
@@ -74,6 +75,23 @@ public void nullValueTest() {
assertNull(reader.timestampValue(0));
}
+ /**
+ * Test boolean value encoding.
+ */
+ @Test
+ public void booleanTest() {
+ boolean[] values = {false, true};
+ for (boolean value : values) {
Review Comment:
nitpicking: it's better to use `@ParameterizedTest` for such cases (see
`org.apache.ignite.internal.tx.TxManagerTest#testTestOnlyPendingCommit` for
example)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
