AMashenkov commented on code in PR #2312:
URL: https://github.com/apache/ignite-3/pull/2312#discussion_r1275197639
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/agg/Accumulators.java:
##########
@@ -118,6 +117,7 @@ private Supplier<Accumulator> avgFactory(AggregateCall
call) {
private Supplier<Accumulator> sumFactory(AggregateCall call) {
switch (call.type.getSqlTypeName()) {
case BIGINT:
+ return () -> new Sum(new LongSumEmptyIsZero());
Review Comment:
What if accumulator value overflows? Can we detect this?
Does SQL standard defines aggregate return types? or it's implementation
defined?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
