lowka commented on code in PR #2312:
URL: https://github.com/apache/ignite-3/pull/2312#discussion_r1275242135
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/MapReduceHashAggregatePlannerTest.java:
##########
@@ -318,11 +324,9 @@ public void expandDistinctAggregates() throws Exception {
.and(input(isInstanceOf(IgniteReduceHashAggregate.class)
.and(not(hasAggregate()))
.and(hasGroups())
- .and(input(isInstanceOf(IgniteExchange.class)
-
.and(input(isInstanceOf(IgniteMapHashAggregate.class)
- .and(not(hasAggregate()))
- .and(hasGroups())
- ))
+
.and(input(isInstanceOf(IgniteMapHashAggregate.class)
+ .and(not(hasAggregate()))
+ .and(hasGroups())
Review Comment:
As I explained earlier the number of projections/aggregate affects cost of a
query plan.
At the moment MAP/REDUCE use the fixed number of columns (GROUP_ID, LIST, ).
After this patch this is no longer holds, add all intermediate expressions are
sent as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
