sanpwc commented on code in PR #2329:
URL: https://github.com/apache/ignite-3/pull/2329#discussion_r1276459414
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -175,7 +184,12 @@ public void handleUpdateAll(
BinaryRow oldRow = storage.addWrite(rowId, row, txId,
commitTblId, commitPartId);
+ if (commitTs != null) { // TODO do in one step.
+ storage.commitWrite(rowId, commitTs);
Review Comment:
Important one: storage.runConsistently() doesn't provide multiple writes
atomicity. In other words if one-phase tx1 writes k1 and k2, tx2 may see only
k1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
