ascherbakoff commented on code in PR #2329:
URL: https://github.com/apache/ignite-3/pull/2329#discussion_r1279481452
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/command/PartitionCommand.java:
##########
@@ -28,4 +28,9 @@ public interface PartitionCommand extends
SafeTimePropagatingCommand {
* Returns a transaction id.
*/
UUID txId();
+
+ /**
+ * Returns {@code true} if a command represents a full transaction.
+ */
+ boolean full();
Review Comment:
onePhaseTransaction is not very good to me.
full means "a full transaction" - including all keys.
the txn is considered one-phase if it fits in one replication command.
I prefer to keep full for now. We can rename it later at any moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
