lowka commented on code in PR #2368:
URL: https://github.com/apache/ignite-3/pull/2368#discussion_r1277427158
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java:
##########
@@ -358,11 +358,22 @@ public void validateAggregateParams(SqlCall aggCall,
public RelDataType deriveType(SqlValidatorScope scope, SqlNode expr) {
RelDataType dataType = super.deriveType(scope, expr);
+ // If type of dynamic parameter has not been inferred, use a type of
its value.
Review Comment:
@zstan I think we should check whether `expr` is a cast expr, and if it
`true`, and then validate its arguments ensure that it is legal cast. Because
at the moment it looks like the check is applied to dynamic parameters in any
expression or maybe I am missing something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
