lowka commented on code in PR #2368:
URL: https://github.com/apache/ignite-3/pull/2368#discussion_r1285439007
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/StatementChecker.java:
##########
@@ -371,14 +387,16 @@ private IgniteSchema createSchema() {
return schema;
}
- private DynamicTest shouldPass(String name, Throwable exception,
Consumer<IgniteRel> check) {
+ private DynamicTest shouldPass(String name, Throwable exception,
Consumer<IgniteRel> check, boolean relCheck) {
return DynamicTest.dynamicTest(name, () -> {
IgniteSchema schema = initSchema(exception);
IgniteRel root;
try {
root = (IgniteRel) sqlPrepare.prepare(schema, sqlStatement,
dynamicParams);
- checkRel(root, schema);
+ if (relCheck) {
Review Comment:
@zstan If this modification hides an issue during
serialisation/deserialization it would have been match better if you mad an
extended version of StatementChecker that mitigates this issue in used for
these test cases.
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/StatementChecker.java:
##########
@@ -371,14 +387,16 @@ private IgniteSchema createSchema() {
return schema;
}
- private DynamicTest shouldPass(String name, Throwable exception,
Consumer<IgniteRel> check) {
+ private DynamicTest shouldPass(String name, Throwable exception,
Consumer<IgniteRel> check, boolean relCheck) {
return DynamicTest.dynamicTest(name, () -> {
IgniteSchema schema = initSchema(exception);
IgniteRel root;
try {
root = (IgniteRel) sqlPrepare.prepare(schema, sqlStatement,
dynamicParams);
- checkRel(root, schema);
+ if (relCheck) {
Review Comment:
@zstan If this modification hides an issue during
serialisation/deserialization it would have been match better if you had an
extended version of StatementChecker that mitigates this issue in used for
these test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
