ascherbakoff commented on code in PR #2329:
URL: https://github.com/apache/ignite-3/pull/2329#discussion_r1279564223
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -326,19 +327,31 @@ private CompletableFuture<?>
processRequest(ReplicaRequest request, @Nullable Bo
if (request instanceof ReadWriteSingleRowReplicaRequest) {
var req = (ReadWriteSingleRowReplicaRequest) request;
- return appendTxCommand(req.transactionId(), req.requestType(), ()
-> processSingleEntryAction(req));
+ return appendTxCommand(req.transactionId(), req.requestType(),
req.full(), () -> processSingleEntryAction(req));
} else if (request instanceof ReadWriteMultiRowReplicaRequest) {
var req = (ReadWriteMultiRowReplicaRequest) request;
- return appendTxCommand(req.transactionId(), req.requestType(), ()
-> processMultiEntryAction(req));
+ return appendTxCommand(req.transactionId(), req.requestType(),
req.full(), () -> processMultiEntryAction(req));
} else if (request instanceof ReadWriteSwapRowReplicaRequest) {
var req = (ReadWriteSwapRowReplicaRequest) request;
- return appendTxCommand(req.transactionId(), req.requestType(), ()
-> processTwoEntriesAction(req));
+ return appendTxCommand(req.transactionId(), req.requestType(),
req.full(), () -> processTwoEntriesAction(req));
} else if (request instanceof
ReadWriteScanRetrieveBatchReplicaRequest) {
var req = (ReadWriteScanRetrieveBatchReplicaRequest) request;
- return appendTxCommand(req.transactionId(), RequestType.RW_SCAN,
() -> processScanRetrieveBatchAction(req));
+ // Implicit RW scan can be committed locally on a last batch or
error.
+ return appendTxCommand(req.transactionId(), RequestType.RW_SCAN,
false, () -> processScanRetrieveBatchAction(req)).handle(
Review Comment:
You are partially correct. All implicit scans can be RO. But, currently
it's possible to create RW-partition scan using internal API. And it has
completely different semantics comparing to RO scans. So, my optimization makes
total sense for this scenario. Until this possibility is removed from code
base, I prefer to retain my optimization in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
