Flaugh24 commented on code in PR #2390: URL: https://github.com/apache/ignite-3/pull/2390#discussion_r1281702018
########## modules/file-transferring/src/main/java/org/apache/ignite/internal/network/file/FileTransferringService.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.file; + +import java.nio.file.Path; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.manager.IgniteComponent; +import org.apache.ignite.internal.network.file.messages.TransferMetadata; + +/** + * File transferring service. + */ +public interface FileTransferringService extends IgniteComponent { + /** + * Adds a file provider for the given metadata. + * + * @param metadata Metadata. + * @param provider Provider. + */ + <M extends TransferMetadata> void addFileProvider( + Class<M> metadata, + FileProvider<M> provider + ); + + /** + * Adds a file handler for the given metadata. + * + * @param metadata Metadata. + * @param handler Handler. + */ + <M extends TransferMetadata> void addFileHandler(Class<M> metadata, FileHandler<M> handler); Review Comment: I don't think so. From my point of view, we should register all providers and handlers on the Ignite startup, and use them during the whole runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
