sk0x50 commented on code in PR #2390:
URL: https://github.com/apache/ignite-3/pull/2390#discussion_r1283203408


##########
modules/core/src/main/java/org/apache/ignite/lang/ErrorGroups.java:
##########
@@ -400,4 +400,15 @@ public static class Compute {
         /** Class loader error. */
         public static final int CLASS_LOADER_ERR = 
COMPUTE_ERR_GROUP.registerErrorCode((short) 2);
     }
+
+    /**
+     * File transfer error group.
+     */
+    public static class FileTransfer {
+        /** File transfer error group. */
+        public static final ErrorGroup FILE_TRANSFER_ERR_GROUP = 
ErrorGroup.newGroup("FILE_TRANSFER", (short) 17);
+
+        /** Generic error. */
+        public static final int GENERIC_ERR = 
FILE_TRANSFER_ERR_GROUP.registerErrorCode((short) 1);

Review Comment:
   Please, avoid using generic error codes, just because it does not make much 
sense to the end user. This must be used with great care.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to