zstan commented on code in PR #2396:
URL: https://github.com/apache/ignite-3/pull/2396#discussion_r1285475218
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -213,31 +191,38 @@ public static BigDecimal toBigDecimal(Object o, int
precision, int scale) {
}
return o instanceof Number ? toBigDecimal((Number) o, precision, scale)
- : toBigDecimal(o.toString(), precision, scale);
+ : toBigDecimal(o.toString(), precision, scale);
}
- /**
- * Converts the given {@code BigDecimal} to a decimal with the given
{@code precision} and {@code scale}
- * according to SQL spec for CAST specification: General Rules, 8.
- */
- public static BigDecimal convertDecimal(BigDecimal value, int precision,
int scale) {
+ /** Convert and validate input. */
+ public static BigDecimal toBigDecimal(Number value, int precision, int
scale) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
