AMashenkov commented on code in PR #2396:
URL: https://github.com/apache/ignite-3/pull/2396#discussion_r1285822349
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -371,8 +372,7 @@ private static Stream<Arguments> decimalCastFromLiterals() {
// TODO Uncomment these test cases after
https://issues.apache.org/jira/browse/IGNITE-19822 is fixed.
arguments(CaseStatus.SKIP, numeric, "100.12", decimalType(5,
1), bigDecimalVal("100.1")),
Review Comment:
Let's also validate RoundingMode.
`arguments(CaseStatus.SKIP, numeric, "100.15", decimalType(5, 1),
bigDecimalVal("100.2")),`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
