tkalkirill commented on code in PR #2413:
URL: https://github.com/apache/ignite-3/pull/2413#discussion_r1285599354
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/CatalogSqlSchemaManager.java:
##########
@@ -70,7 +71,7 @@ public CatalogSqlSchemaManager(CatalogManager catalogManager,
int cacheSize) {
/** {@inheritDoc} */
@Override
- public SchemaPlus schema(String name, int version) {
+ public @Nullable SchemaPlus schema(String name, int version) {
Review Comment:
`String name` can be `null` not return value =)
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/PredefinedSchemaManager.java:
##########
@@ -60,21 +63,21 @@ public class PredefinedSchemaManager implements
SqlSchemaManager {
schema.getTableNames().stream()
.map(schema::getTable)
.map(IgniteTable.class::cast)
-
.collect(CollectionUtils.toIntMapCollector(IgniteTable::id,
Function.identity()))
+ .collect(toIntMapCollector(IgniteTable::id,
Function.identity()))
Review Comment:
maybe also `Function.identity()` -> `identity()` wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
