korlov42 commented on code in PR #2413:
URL: https://github.com/apache/ignite-3/pull/2413#discussion_r1285949035
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##########
@@ -330,7 +330,10 @@ private AsyncCursor<List<Object>>
executeExplain(ExplainPlan plan) {
private void onMessage(String nodeName, QueryStartRequest msg) {
assert nodeName != null && msg != null;
- CompletableFuture<?> fut =
sqlSchemaManager.actualSchemaAsync(msg.schemaVersion());
+ //TODO IGNITE-18733: We should use txTimestamp from message tx
attributes to wait for metadata ready,
+ // then get actual version for txTimestamp and wait for catalog
version ready.
+ // As optimization, we can lookup for latest available schema and go
sync way if it's version >= desirable.
Review Comment:
in my opinion, this is not quite correct. It's better to use catalog version
explicitly whenever possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
