tkalkirill commented on code in PR #2448:
URL: https://github.com/apache/ignite-3/pull/2448#discussion_r1298222844
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java:
##########
@@ -119,19 +102,17 @@ public DistributionZoneRebalanceEngine(
* Starts the rebalance engine by registering corresponding meta storage
and configuration listeners.
*/
public void start() {
- if (!busyLock.enterBusy()) {
- throw new IgniteException(NODE_STOPPING_ERR, new
NodeStoppingException());
- }
-
- try {
-
zonesConfiguration.defaultDistributionZone().replicas().listen(onUpdateReplicas);
-
zonesConfiguration.distributionZones().any().replicas().listen(onUpdateReplicas);
+ IgniteUtils.inBusyLock(busyLock, () -> {
Review Comment:
Why remove the listener if the node leaves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
