sanpwc commented on code in PR #2448:
URL: https://github.com/apache/ignite-3/pull/2448#discussion_r1298714116
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -202,7 +205,7 @@ public class DistributionZoneManager implements
IgniteComponent {
* Map with states for distribution zones. States are needed to track
nodes that we want to add or remove from the data nodes,
* schedule and stop scale up and scale down processes.
*/
- private final Map<Integer, ZoneState> zonesState;
+ private final Map<Integer, ZoneState> zonesState = new
ConcurrentHashMap<>();
Review Comment:
Because for the consistence purposes it's better to initialize properties in
one place.
##########
modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java:
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.catalog;
+
+import static
org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willCompleteSuccessfully;
+import static org.hamcrest.MatcherAssert.assertThat;
+
+import org.apache.ignite.internal.catalog.storage.UpdateLogImpl;
+import org.apache.ignite.internal.hlc.HybridClock;
+import org.apache.ignite.internal.metastorage.MetaStorageManager;
+import
org.apache.ignite.internal.metastorage.impl.StandaloneMetaStorageManager;
+import
org.apache.ignite.internal.metastorage.server.SimpleInMemoryKeyValueStorage;
+import org.apache.ignite.internal.vault.VaultManager;
+import org.apache.ignite.internal.vault.inmemory.InMemoryVaultService;
+
+/**
+ * Utilities for working with the catalog in tests.
+ */
+public class CatalogTestUtils {
+ /**
+ * Creates a test implementation of {@link CatalogManager}.
+ *
+ * <p>NOTE: Uses {@link CatalogManagerImpl} under the hood and creates the
internals it needs, may change in the future.
+ *
+ * @param nodeName Node name.
+ * @param clock Hybrid clock.
+ */
+ public static CatalogManager createTestCatalogManager(String nodeName,
HybridClock clock) {
+ var vault = new VaultManager(new InMemoryVaultService());
+
+ var metastore = StandaloneMetaStorageManager.create(vault, new
SimpleInMemoryKeyValueStorage(nodeName));
Review Comment:
Seems that it's not valid to use var in given case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
