rpuch commented on code in PR #2450:
URL: https://github.com/apache/ignite-3/pull/2450#discussion_r1302642650
##########
modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/TestIgnitionManager.java:
##########
@@ -100,20 +104,35 @@ private static InitParameters
applyTestDefaultsToClusterConfig(InitParameters pa
.metaStorageNodeNames(params.metaStorageNodeNames())
.cmgNodeNames(params.cmgNodeNames());
+ ConfigDocument configDocument;
+
if (params.clusterConfiguration() == null) {
- builder.clusterConfiguration("{ schemaSync.delayDuration: 0 }");
+ configDocument = ConfigDocumentFactory.parseString("{}");
} else {
- ConfigDocument configDocument =
ConfigDocumentFactory.parseString(params.clusterConfiguration());
+ configDocument =
ConfigDocumentFactory.parseString(params.clusterConfiguration());
+ }
- String delayDurationPath = "schemaSync.delayDuration";
+ configDocument = applyTestDefault(
Review Comment:
If someone wants to run a cluster with a different value of some
cluster-wide config property, they would use `TestIgnitionManager#init()`
passing the config they need. The code we are looking at now is about DEFAULT
values used if no explicit value was supplied when initializing the cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
